Playbook/role validation fixes (by Steampunk Spotter) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
gberginc
changed the title
Previously used msg parameter is now replaced with the new fail_msg. Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
According to the documentation, the parameter to speciffy the profile should be named profiles (plural), even if there is just one profile. This patch replaces two occurrences. Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
According to the documentation, the new parameters are name (instead of value) and type (instead of datatype). This patch renames these occurrences. Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
gberginc
force-pushed
the
steampunk_spotter_fixes
branch
from
7377290 to
1527793
Compare
|
Great finds I noticed your dco was bad but upon refreshing the page it looks like you have resolved that as I am typing this out. |
|
Yeah, I just noticed DCO messages and signedoff my commits. Thanks for getting back to me. We found some issues in other repos as well - is it ok to submit them as well? |
|
Certainly! Thanks for the help, and feel free to jump in the discord if you want to chat about any of them. |
MrSteve81
reviewed
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
I've used Steampunk Spotter to run some checks and noticed few errors and suggestions within the playbooks/roles, regarding the used parameters in some of the tasks. Not sure if you are accepting this kind of PRs.
Enhancements:
Not sure if there is a workaround, but according to the specification of module
community.windows.win_firewallshould be usingprofilesparameter instead ofprofile.This PR also fixes some other parameters that were renamed in the latest versions (albeit previous versions still work as aliases, it's good practice to keep them up to date).
How has this been tested?:
N/A