Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 March Update: Updates from Sep2023 Branch, Typo fixes and improved reboot notify #42

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

frederickw082922
Copy link
Contributor

@frederickw082922 frederickw082922 commented Mar 20, 2024

Overall Review of Changes:

  • September 2023 Updates

    • Bug Fixes
    • Added Updated Discord Links
    • Updated Galaxy Score Links
    • Updated Readme
    • Control 18.2.6 - Fixed Spelling For Member server
    • Control 18.3.1 - Adjusted when statement for Member server only.
    • PR'S Closed

      #37 - 9.2.1/9.3.1 Fixed Module Parameters in win_firewall - Thanks @gberginc

      #37 - Section 18 Fixed Module Parameters in win_regedit - Thanks @gberginc
    • Reviewed all DC Only and MS Only Controls to verify when statements are valid.
    • Updated win_skip_for_test controls
  • August 2023 Updates

    • Updated to Central org based workflow.
    • Updated Linting files and ran against playbook
    • All modules fit FQCN standard.
    • Updated Readme.md

Issue Fixes:
#37

Enhancements:
Reboot Notify Enhancements

How has this been tested?:
Locally and Azure

Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@frederickw082922 frederickw082922 merged commit 1f5f542 into devel Mar 20, 2024
3 checks passed
@frederickw082922
Copy link
Contributor Author

Thank you @MrSteve81 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants