Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #119] Fix latest version and language for version archives #120

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Jul 31, 2023

Fixes #119.

Please merge this PR after #118.

Relevant pr: #108

  1. Fixed 1.9.0 is released however 1.8.0 is displayed by default
  2. Fixed English documents are displayed in Chinese site (in current or "Next" version)
  3. Added missing json configuration to fix English columns are displayed in Chinese site (in 1.8.0/1.9.0 latest version)
  4. Some doc title optimization
  5. Fixed a document that didn't show up

Before

image

image

After

image

image

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jul 31, 2023

PR #108 introduced some bugs, basically all of which have been fixed by me. However, the current multi-version mechanism does not allow for version control in a single file.

To release a new version after merging this pr, you need to change the following locations:

zh doc: eventmesh-site\i18n\zh\docusaurus-plugin-content-docs\version-v1.9.0
zh column config: eventmesh-site\i18n\zh\docusaurus-plugin-content-docs\version-v1.9.0.json
en doc: eventmesh-site\versioned_docs\version-v1.9.0
eventmesh-site\versions.json

There is still one known issue: the historical version is only available in English, without Chinese. Since I don't know if the community needs these historical versions, I'll mention it in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix latest version and language for version archives
3 participants