Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zh copywriting by use AutoCorrect. #226

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Fix zh copywriting by use AutoCorrect. #226

merged 4 commits into from
Jul 11, 2024

Conversation

huacnlee
Copy link
Contributor

Ref #225

@huacnlee huacnlee mentioned this pull request Jun 18, 2024
Merged
@Pil0tXia Pil0tXia mentioned this pull request Jun 19, 2024
Open
@huacnlee huacnlee mentioned this pull request Jun 20, 2024
Closed
@huacnlee huacnlee force-pushed the fix-zh branch 3 times, most recently from e16e07a to 1284e15 Compare June 20, 2024 13:58
@Pil0tXia
Copy link
Member

@huacnlee #227 merged. You can pull changes from the master branch to exclude the versioned_docs path in this PR.

@huacnlee
Copy link
Contributor Author

There is no versioned_docs path in the changes diff, do you means the version-* folders?

@Pil0tXia
Copy link
Member

@huacnlee I mean that the changes made in this conversation have been merged in master branch, but haven't been made in this PR. So you can merge master branch into this PR to update.

@huacnlee
Copy link
Contributor Author

Ok, now have pushed.

@Pil0tXia
Copy link
Member

Pil0tXia commented Jun 22, 2024 •
edited
Loading

@huacnlee Then you can roll back the changes or rerun the formatting to make sure that the historical documents in the versioned_docs directory are not changed.

@huacnlee
Copy link
Contributor Author

I have checked, there is no versioned_docs folder changes.

@Pil0tXia
Copy link
Member

@huacnlee No, there're plenty versioned_docs folder changes currently. Please check https://github.com/apache/eventmesh-site/pull/226/files.

image

@huacnlee huacnlee requested a review from Pil0tXia July 10, 2024 12:52
@huacnlee
Copy link
Contributor Author

@Pil0tXia Please review again, I have update.

Pil0tXia
Pil0tXia reviewed Jul 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/design-document/03-connect/11-kafka-connector.md Outdated
Comment on lines 49 to 51
connectorName: kafkaSource
# kafka连接参数 ↓
# kafka 连接参数 ↓
bootstrapServers: 127.0.0.1:9092
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in https://github.com/apache/eventmesh-site/compare/4432a124c26ed09e036c1ff837744e46d8944def..82acf2ed071c0c098faf9b1feff2613c79e1ba44, the content within the code block has been reformatted again. Why has this occurred?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I am installed wrong version of AutoCorrect, it not have that feature.

@Pil0tXia
Copy link
Member

image

I noticed that some valuable changes have been rolled back. Were these intentional?

@huacnlee
Copy link
Contributor Author

Yes, I have reverted all and run autocorrect again. Because it was too long ago, I have forgotten what about for this file. Would you please just to edit PR to change what you want?

@Pil0tXia
Copy link
Member

Never mind, those changes are basically minor glitches.

@Pil0tXia Pil0tXia merged commit e602114 into apache:master Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pil0tXia Pil0tXia Pil0tXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huacnlee @Pil0tXia