-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIE-781] Improve performance of InfixOpNode #5634
Conversation
Thanks @mariofusco |
The failures seems to be totally unrelated with this pull request. In particular I see that the failure of the build of
but I'm totally unable to reproduce this problem locally, it successful for me and indeed the generated pom is identical to the expected one. Any clue on how we can further investigate this issue? |
Could it be related to depenbdabot changes ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mariofusco nice improvements!
This is a fix for the performance issue reported with this comment.
Running the same benchmark against this commit I got the following results
that are much better of the current situation but also around 20% faster than what we had on 8.44.0.Final that was
I believe that there is still room for improvement, but this seems a step in the right direction that however will need to be validated with more extensive benchmarks before being merged.