Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIE-781] Improve performance of InfixOpNode #5634

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

mariofusco
Copy link
Contributor

This is a fix for the performance issue reported with this comment.

Running the same benchmark against this commit I got the following results

Benchmark                  (argsType)   Mode  Cnt     Score    Error   Units
FEELInfixOpBenchmark.eval      String  thrpt   10  4398.719 ± 12.653  ops/ms
FEELInfixOpBenchmark.eval         int  thrpt   10  4303.348 ± 17.151  ops/ms

that are much better of the current situation but also around 20% faster than what we had on 8.44.0.Final that was

Benchmark                  (argsType)   Mode  Cnt     Score    Error   Units
FEELInfixOpBenchmark.eval      String  thrpt   10  3866.743 ± 30.992  ops/ms
FEELInfixOpBenchmark.eval         int  thrpt   10  3367.492 ± 11.529  ops/ms

I believe that there is still room for improvement, but this seems a step in the right direction that however will need to be validated with more extensive benchmarks before being merged.

@gitgabrio
Copy link
Contributor

Thanks @mariofusco
FYI I just pushed specific benchmarks here (under org.drools.benchmarks.dmn.feel.infixexecutors)
Maybe you can give them a try

@mariofusco
Copy link
Contributor Author

The failures seems to be totally unrelated with this pull request. In particular I see that the failure of the build of KIE :: Drools DMN engine Maven Archetype is caused by this:

2023-12-19T17:13:49.5295647Z [INFO] Project created from Archetype in dir: /home/runner/work/incubator-kie-drools/incubator-kie-drools/apache_incubator-kie-drools/kie-archetypes/kie-drools-dmn-archetype/target/test-classes/projects/integrationtestDefaults/project/basic
2023-12-19T17:13:49.5300304Z [INFO] Comparing generated project with reference content: /home/runner/work/incubator-kie-drools/incubator-kie-drools/apache_incubator-kie-drools/kie-archetypes/kie-drools-dmn-archetype/target/test-classes/projects/integrationtestDefaults/reference
2023-12-19T17:13:49.5326002Z [WARNING] Contents of file pom.xml are not equal

but I'm totally unable to reproduce this problem locally, it successful for me and indeed the generated pom is identical to the expected one. Any clue on how we can further investigate this issue?

@gitgabrio
Copy link
Contributor

The failures seems to be totally unrelated with this pull request. In particular I see that the failure of the build of KIE :: Drools DMN engine Maven Archetype is caused by this:

2023-12-19T17:13:49.5295647Z [INFO] Project created from Archetype in dir: /home/runner/work/incubator-kie-drools/incubator-kie-drools/apache_incubator-kie-drools/kie-archetypes/kie-drools-dmn-archetype/target/test-classes/projects/integrationtestDefaults/project/basic
2023-12-19T17:13:49.5300304Z [INFO] Comparing generated project with reference content: /home/runner/work/incubator-kie-drools/incubator-kie-drools/apache_incubator-kie-drools/kie-archetypes/kie-drools-dmn-archetype/target/test-classes/projects/integrationtestDefaults/reference
2023-12-19T17:13:49.5326002Z [WARNING] Contents of file pom.xml are not equal

but I'm totally unable to reproduce this problem locally, it successful for me and indeed the generated pom is identical to the expected one. Any clue on how we can further investigate this issue?

Could it be related to depenbdabot changes ?

<version.logback>1.2.9</version.logback> -> <version.logback>1.2.13</version.logback>

immagine

#5613
#5614
#5615
#5616

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mariofusco nice improvements!

@mariofusco mariofusco merged commit 2094023 into apache:main Dec 20, 2023
6 of 9 checks passed
@mariofusco mariofusco deleted the kie781 branch December 20, 2023 09:24
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants