Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bugfix): for txn_write_batch creation #2648

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Nov 4, 2024

  // backup_index_comparator: the backup comparator used to compare keys
  // within the same column family, if column family is not given in the
  // interface, or we can't find a column family from the column family handle
  // passed in, backup_index_comparator will be used for the column family.
  // reserved_bytes: reserved bytes in underlying WriteBatch
  // max_bytes: maximum size of underlying WriteBatch in bytes
  // overwrite_key: if true, overwrite the key in the index when inserting
  //                the same key as previously, so iterator will never
  //                show two entries with the same key.
  explicit WriteBatchWithIndex(
      const Comparator* backup_index_comparator = BytewiseComparator(),
      size_t reserved_bytes = 0, bool overwrite_key = false,
      size_t max_bytes = 0, size_t protection_bytes_per_key = 0);

Our ctor doesn't following the right ordering

@mapleFU
Copy link
Member Author

mapleFU commented Nov 4, 2024

torwig
torwig previously approved these changes Nov 4, 2024
Copy link

sonarcloud bot commented Nov 4, 2024

@mapleFU mapleFU merged commit c01b00e into apache:unstable Nov 5, 2024
32 checks passed
@mapleFU mapleFU deleted the minor-fix-for-txn-write-batch branch November 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants