Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bugfix): for txn_write_batch creation #2648

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix(bugfix): for txn_write_batch creation #2648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd2663
Bugfix for txn_write_batch creation
mapleFU Nov 4, 2024
610bd39
Merge branch 'unstable' into minor-fix-for-txn-write-batch
PragmaTwice Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/storage/storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,9 +868,11 @@ Status Storage::BeginTxn() {
// The EXEC command is exclusive and shouldn't have multi transaction at the same time,
// so it's fine to reset the global write batch without any lock.
is_txn_mode_ = true;
txn_write_batch_ =
std::make_unique<rocksdb::WriteBatchWithIndex>(rocksdb::BytewiseComparator() /*default backup_index_comparator */,
0 /* default reserved_bytes*/, GetWriteBatchMaxBytes());
// Set overwrite_key to false to avoid overwriting the existing key in case
// like downstream would parse the replication log etc.
txn_write_batch_ = std::make_unique<rocksdb::WriteBatchWithIndex>(
/*backup_index_comparator=*/rocksdb::BytewiseComparator(),
/*reserved_bytes=*/0, /*overwrite_key=*/false, /*max_bytes=*/GetWriteBatchMaxBytes());
return Status::OK();
}

Expand Down
Loading