Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newt: Fix config check for entries with description #570

Merged
merged 1 commit into from
Sep 9, 2024
Merged

newt: Fix config check for entries with description #570

merged 1 commit into from
Sep 9, 2024

Commits on Sep 9, 2024

  1. newt: Fix config check crashes 

    We should use DeepEqual to compare interface values.
In some cases Value interface might contain a map
with some more keys than just "value" key - for
example "description" key. This will cause
DeepEqual to fail, even if the "value" keys
would be the same. However before returning an error
we also check if Expr field of both entries
is not nil. We can assume that in that
case no additional keys in map will be present
and no false positive error will be returned.
    @m-gorecki
    m-gorecki committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3de9cc1 View commit details
    Browse the repository at this point in the history