newt: Fix config check for entries with description #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gorecki
force-pushed
the
dupcheck-fix
branch
from
e12a7be
to
d480dec
Compare
We should use DeepEqual to compare interface values. In some cases Value interface might contain a map with some more keys than just "value" key - for example "description" key. This will cause DeepEqual to fail, even if the "value" keys would be the same. However before returning an error we also check if Expr field of both entries is not nil. We can assume that in that case no additional keys in map will be present and no false positive error will be returned.
m-gorecki
force-pushed
the
dupcheck-fix
branch
from
d480dec
to
3de9cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use DeepEqual to compare interface values.
In some cases Value interface might contain a map
with some more keys than just "value" key - for
example "description" key. This will cause
DeepEqual to fail, even if the "value" keys
would be the same. However before returning an error
we also check if Expr field of both entries
is not nil. We can assume that in that
case no additional keys in map will be present
and no false positive error will be returned.