nimble/ll: solve issue with duplicated ISO flags #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKopyscinski
force-pushed
the
ll_iso_fix_flags
branch
2 times, most recently
from
c8a6fe5
to
744b51b
Compare
This patch removes boilerplate for ISO code. This code causes conflicts when proper implementation is introduced, as new LL flags are introduced. This causes bugs like duplicated case for BLE_HCI_OCF_LE_READ_ISO_TX_SYNC OP Code. Unsupported functions were removed, along with BLE_LL_CFG_FEAT_LL_ISO and BLE_LL_CFG_FEAT_LL_ISO_TEST flag (BLE_LL_ISO and BLE_LL_ISO_TEST are currently used). BLE_ISO_BROADCAST flag was introduced, and BLE_LL_ISO_BROADCASTER inherits its value, by default. Similary, BLE_LL_ISO inherits default value from BLE_ISO now.
Silences error: 'hci_ev_ncp' may be used uninitialized: it is derived from hci_ev, and only used when hci_ev != NULL. So it'll never be NULL when used.
KKopyscinski
force-pushed
the
ll_iso_fix_flags
branch
from
bc74ae7
to
604225d
Compare
|
@andrzej-kaczmarek as discussed offline, I removed code that caused errors. I also checked LL ISO command structs in |
KKopyscinski
changed the title
andrzej-kaczmarek
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes MYNEWT_VAL flags consistent: BLE_LL_CFG_FEAT_LL_ISO defines same functionality as BLE_LL_ISO, and the latter shall be used.
Removed duplicated case in ble_ll_hci_le_cmd_proc for BLE_HCI_OCF_LE_READ_ISO_TX_SYNC OP code.