Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimble/ll: solve issue with duplicated ISO flags #1641

Merged
merged 3 commits into from
Oct 17, 2023
Merged

nimble/ll: solve issue with duplicated ISO flags #1641

merged 3 commits into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. nimble/ll: remove unsupported ISO code and configs 

    This patch removes boilerplate for ISO code. This code causes conflicts
when proper implementation is introduced, as new LL flags are
introduced.

This causes bugs like duplicated case for
BLE_HCI_OCF_LE_READ_ISO_TX_SYNC OP Code.

Unsupported functions were removed, along with BLE_LL_CFG_FEAT_LL_ISO
and BLE_LL_CFG_FEAT_LL_ISO_TEST flag (BLE_LL_ISO and BLE_LL_ISO_TEST are
currently used). BLE_ISO_BROADCAST flag was introduced, and
BLE_LL_ISO_BROADCASTER inherits its value, by default. Similary, BLE_LL_ISO
inherits default value from BLE_ISO now.
    @KKopyscinski
    KKopyscinski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c242004 View commit details
    Browse the repository at this point in the history

  2. nimble/ll: silence compiler warning in ble_ll_iso_big_event_done 

    Silences error: 'hci_ev_ncp' may be used uninitialized: it is derived
from hci_ev, and only used when hci_ev != NULL. So it'll never be NULL
when used.
    @KKopyscinski
    KKopyscinski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6fee59c View commit details
    Browse the repository at this point in the history

  3. CI: add BLE_ISO_BROADCASTER to test_build_apps_syscfg.yml

    @KKopyscinski
    KKopyscinski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    604225d View commit details
    Browse the repository at this point in the history