Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1819: [FOLLOWUP] Fix baseurl parameter and more links #2099

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 4, 2025

What changes were proposed in this pull request?

This is a follow-up to fix baseurl parameter and more links.

Why are the changes needed?

baseurl option is defined like the following.

Base URL: Serve the website from the given base URL (the path between web-server or domain root and your landing page).

This only updates https://apache.github.io/orc/ while keeping https://orc.apache.org unchanged.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this, @williamhyun ?

@williamhyun
Copy link
Member

+1 LGTM.
Thank you for the follow-up fix, will be merging this now.

@dongjoon-hyun
Copy link
Member Author

Thank you, William!

@dongjoon-hyun dongjoon-hyun deleted the links branch January 5, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants