Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Goerli testnets #1974

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Conversation

vanshwassan
Copy link
Contributor

Some of the testnets based on Goerli are now officially deprecated. Some of them also caused the CI runs to fail. Removed the following Goerli testnets:

Also deployed protocol contracts to the newer Sepolia Testnets:

This PR cannot be merged until the newer Sepolia testnets are added in the @api3/chains package.

@dcroote
Copy link
Contributor

dcroote commented Mar 19, 2024

I'm fine with removing these goerli chains since they're all deactivated / decommissioned (rather than just deprecated).

@dcroote dcroote linked an issue Mar 23, 2024 that may be closed by this pull request
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the newly added Arbitrum Sepolia Testnet is failing verification..?

@vanshwassan
Copy link
Contributor Author

vanshwassan commented Apr 1, 2024

Looks like the newly added Arbitrum Sepolia Testnet is failing verification..?

Yeah, I noticed that running deploy:deterministic command didn't add the transactionHash and receipt in the json files for arbitrum-sepolia for some reason. Not sure why, but I generated the receipt and added those fields manually.

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I generated the receipt and added those fields manually.

Nice 👍 Not sure why the ethereum goerli and polygon testnet verifications are failing, but we know they're ok

@Ashar2shahid Ashar2shahid merged commit 38bd229 into master Apr 8, 2024
28 of 29 checks passed
@Ashar2shahid Ashar2shahid deleted the remove-deprecated-chains branch April 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove arbitrum-goerli-testnet support
3 participants