Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Avoid exhausting file descriptors, disable secp256 tests #42

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[CI] Avoid exhausting file descriptors, disable secp256 tests #42

merged 1 commit into from
Oct 16, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Oct 13, 2023 •
edited
Loading

Description

This PR does two things:

  1. @0xmaayan observed that sometimes running the full test suite would result in the machine running out of fds. We help avoid this by limiting concurrency in jest. I timed it, on my machine this doesn't seem to affect how long the tests take overall.
  2. The user txn processor currently breaks when handling txns with secp256. This is the case across all networks and in main, so it's just totally broken upstream. This PR skips those tests for now to make CI green.

Test Plan

See CI run.

Related Links

@banool banool force-pushed the banool/testing-ports branch from 8f32333 to 4ad3bcc Compare October 13, 2023 18:01
gregnazario
gregnazario requested changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not letting you land it :)

@banool banool force-pushed the banool/testing-ports branch 4 times, most recently from 2c5a96b to a1d8154 Compare October 16, 2023 01:28
@banool banool changed the title TEST DO NOT LAND LOOKING AT PORTS [CI] Avoid exhausting file descriptors, disable secp256 tests Oct 16, 2023
@banool banool force-pushed the banool/testing-ports branch from a1d8154 to fa03a8b Compare October 16, 2023 01:31
@banool banool marked this pull request as ready for review October 16, 2023 01:34
@banool banool requested review from 0xmaayan, 0xmigo, heliuchuan and a team as code owners October 16, 2023 01:34
0xmaayan
0xmaayan reviewed Oct 16, 2023
View reviewed changes
tests/e2e/transaction/transaction_simulation.test.ts
@@ -210,7 +210,7 @@ describe("transaction simulation", () => {

describe("Secp256k1", () => {
Copy link
Collaborator

@0xmaayan 0xmaayan Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can just describe.skip(...)

@0xmaayan
Copy link
Collaborator

0xmaayan commented Oct 16, 2023 •
edited
Loading

  1. The user txn processor currently breaks when handling txns with secp256. This is the case across all networks and in main, so it's just totally broken upstream. This PR skips those tests for now to make CI green.

thats weird.... I was able to run secp256k1 tests separately on devnet

@0xmaayan 0xmaayan mentioned this pull request Oct 16, 2023
Closed
@banool
Copy link
Contributor Author

banool commented Oct 16, 2023

Idk Larry says it's meant to be broken on both? I'll look into it, maybe he landed a fix.

@0xmaayan 0xmaayan merged commit e7ed9e8 into main Oct 16, 2023
@0xmaayan 0xmaayan deleted the banool/testing-ports branch October 16, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmaayan 0xmaayan 0xmaayan approved these changes

@gregnazario gregnazario gregnazario approved these changes

@0xmigo 0xmigo Awaiting requested review from 0xmigo

@heliuchuan heliuchuan Awaiting requested review from heliuchuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banool @0xmaayan @gregnazario