Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize and fix callback detection #1001

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

dalg24
Copy link
Contributor

@dalg24 dalg24 commented Dec 28, 2023

Refactor/ modernize callback introspection facility. My initial goal was to get rid of Details::AccessTraitsHelper but I decided to split that up.

Fix bug introduced the refactor in #939 that makes that we were not catching errors like

// check_valid_callback<int>(CustomCallbackMissingConstQualifier{},
// SpatialPredicates{});
))

@dalg24 dalg24 added bug Something isn't working refactoring Code reorganization labels Dec 28, 2023
Copy link
Contributor

@aprokop aprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aprokop aprokop merged commit fffb2e0 into arborx:master Dec 28, 2023
1 of 2 checks passed
@dalg24 dalg24 deleted the modernize_callback_detection branch December 28, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring Code reorganization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants