chore: Optimize e2e tests by removing redundant ensure clean state + some refactoring #20939
+23
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some refactoring Closes argoproj#20938 There's no need to do multiple ensure clean state in tests, which `Given` does, so using `GivenWithSameState` in places not using it already. There were only a few, so I don't expect a big win, but it may help with test consistency as well. Also, refactor to use `Given` and `GivenWithSameState` for repo fixture instead of `Given(t, <bool>)`. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20939 +/- ##
=========================================
Coverage ? 55.04%
=========================================
Files ? 324
Lines ? 55465
Branches ? 0
=========================================
Hits ? 30531
Misses ? 22319
Partials ? 2615 ☔ View full report in Codecov by Sentry. |
|
Seems to save ~1 minute. |
…dant-ensure-clean-state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20938
There's no need to do multiple ensure clean state in tests, which
Givendoes, so usingGivenWithSameStatein places not using it already. There were only a few, so I don't expect a big win, but it may help with test consistency as well. Also, refactor to useGivenandGivenWithSameStatefor repo fixture instead ofGiven(t, <bool>).Checklist: