Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Optimize e2e tests by removing redundant ensure clean state + some refactoring #20939

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: Optimize e2e tests by removing redundant ensure clean state + some refactoring #20939

wants to merge 2 commits into from
+23 −23

Commits on Nov 25, 2024

  1. chore: Optimize e2e tests by removing redundant ensure clean state + … 

    …some refactoring

Closes argoproj#20938

There's no need to do multiple ensure clean state in tests, which `Given` does, so using `GivenWithSameState` in places not using it already. There were only a few, so I don't expect a big win, but it may help with test consistency as well.
Also, refactor to use `Given` and `GivenWithSameState` for repo fixture instead of `Given(t, <bool>)`.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3777936 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 20938-optimize-e2e-tests-by-removing-redun… 

    …dant-ensure-clean-state
    @blakepettersson
    blakepettersson authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    681ab4b View commit details
    Browse the repository at this point in the history