Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create .github/CODEOWNERS #2658

Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Jun 15, 2023

This ensures PRs get reviewers. Currently they do not

removed due to not having write permissions on repo anymore (according to the CODEOWNERS file itself)

Screenshot 2023-06-15 at 11 38 21 AM

@jmeridth
Copy link
Member Author

@VaibhavPage @whynowy @edlee2121 @jessesuen I promise I'm not voluntolding you. Your names were in the former OWNERS file. Please let me know if you want your name removed.

@jmeridth
Copy link
Member Author

e2e tests are failing. Going to run locally to see what's going on.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@whynowy
Copy link
Member

whynowy commented Jun 23, 2023

Please keep the OWNERS file, we use it to track different roles.

@jmeridth jmeridth changed the title chore: move OWNERS file content to .github/CODEOWNERS chore: create .github/CODEOWNERS Jun 24, 2023
This ensures PRs get reviewers.  Currently they do not

- removed due to not having write permissions on repo anymore
 - daniel-codefresh
 - dtaniwaki

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth force-pushed the jm/convert-owners-file-to-codeowners branch from 1412c83 to 7393a86 Compare June 24, 2023 15:11
@jmeridth jmeridth requested review from whynowy and mbevc1 June 24, 2023 15:19
@whynowy whynowy merged commit 9a779af into argoproj:master Jun 25, 2023
@jmeridth jmeridth deleted the jm/convert-owners-file-to-codeowners branch June 25, 2023 23:42
whynowy pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: jmeridth <jmeridth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants