Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: idempotency of setup logger #981

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Dec 24, 2024

Description

Great news everyone - it is now MUCH faster to run the tests.. Locally it means 9s vs 74s for my machine.

The issue was that we were adding too many RichHandler when calling CliRunner multiple times...

NOTE: Logging need some more love.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc added this to the v1.3.0 milestone Dec 24, 2024
@gmuloc gmuloc force-pushed the remove-many-handlers branch from c175f7d to 90a28d6 Compare December 24, 2024 16:39
@gmuloc gmuloc changed the title WIP: idempotency of setup logger Test: idempotency of setup logger Dec 24, 2024
@gmuloc gmuloc marked this pull request as ready for review December 24, 2024 16:46
@gmuloc gmuloc changed the title Test: idempotency of setup logger test: idempotency of setup logger Dec 24, 2024
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #981 will not alter performance

Comparing gmuloc:remove-many-handlers (b17dde6) with main (2a0bf6c)

Summary

✅ 22 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant