Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: idempotency of setup logger #981

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: idempotency of setup logger #981

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc2a01c
WIP: idempotency of setup logger
gmuloc Dec 24, 2024
1971870
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 24, 2024
90a28d6
Refactor(anta): Avoid adding the Rich handler multiple times
gmuloc Dec 24, 2024
b17dde6
Fix: With the correct logic #yolo
gmuloc Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions anta/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,20 @@ def setup_logging(level: LogLevel = Log.INFO, file: Path | None = None) -> None:
# httpx as well
logging.getLogger("httpx").setLevel(logging.WARNING)

# Add RichHandler for stdout
rich_handler = RichHandler(markup=True, rich_tracebacks=True, tracebacks_show_locals=False)
# Show Python module in stdout at DEBUG level
fmt_string = "[grey58]\\[%(name)s][/grey58] %(message)s" if loglevel == logging.DEBUG else "%(message)s"
formatter = logging.Formatter(fmt=fmt_string, datefmt="[%X]")
rich_handler.setFormatter(formatter)
root.addHandler(rich_handler)
# Add RichHandler for stdout if not already present
maybe_add_rich_handler = True
if root.hasHandlers():
maybe_add_rich_handler = all(handler.get_name() != "ANTA_RICH_HANDLER" for handler in root.handlers)

if maybe_add_rich_handler:
rich_handler = RichHandler(markup=True, rich_tracebacks=True, tracebacks_show_locals=False)
rich_handler.set_name("ANTA_RICH_HANDLER")
# Show Python module in stdout at DEBUG level
fmt_string = "[grey58]\\[%(name)s][/grey58] %(message)s" if loglevel == logging.DEBUG else "%(message)s"
formatter = logging.Formatter(fmt=fmt_string, datefmt="[%X]")
rich_handler.setFormatter(formatter)
root.addHandler(rich_handler)

# Add FileHandler if file is provided
if file:
file_handler = logging.FileHandler(file)
Expand Down
Loading