feat: validate tsconfig outDir vs ts_project(out_dir)

[Mivr]

Changes are visible to end-users: no

Test plan

• New test cases added

Resolves: #644

By adding a validation to the tsconfig file. If a out_dir parameter is set to the rule and the tsconfig file does not have the exclude key set the build will fail

[aspect-workflows]

Test

⚠️ GitHub Actions build #1115 failed.

//examples/transpiler:babel failed to build

remote spawn failed: UNIMPLEMENTED: Failed to route action: Failed to analyze initial size class: Failed to read previous execution stats for reduced action digest "1-74756d07ff0869dd2641455b91569e397f9e4653b3456b1be55f6ddf3c663146-232-": Failed to read mutable Protobuf message with digest "1-74756d07ff0869dd2641455b91569e397f9e4653b3456b1be55f6ddf3c663146-232-": Shard 1: unknown service buildbarn.iscc.InitialSizeClassCache

remote spawn failed: UNIMPLEMENTED: Failed to route action: Failed to analyze initial size class: Failed to read previous execution stats for reduced action digest "1-cd2b0635d7d8741f0a3681caa747acfbaf87912aec5bfb83375fefe554c389e3-232-": Failed to read mutable Protobuf message with digest "1-cd2b0635d7d8741f0a3681caa747acfbaf87912aec5bfb83375fefe554c389e3-232-": Shard 0: unknown service buildbarn.iscc.InitialSizeClassCache

//examples/lib_nocompile_linked:lib failed to build

remote spawn failed: UNIMPLEMENTED: Failed to route action: Failed to analyze initial size class: Failed to read previous execution stats for reduced action digest "1-73635a7baf60e6d0f384bb6b6cc9a12565f6a982538cc951bad81ba7deba1b36-232-": Failed to read mutable Protobuf message with digest "1-73635a7baf60e6d0f384bb6b6cc9a12565f6a982538cc951bad81ba7deba1b36-232-": Shard 2: unknown service buildbarn.iscc.InitialSizeClassCache

//examples/no_emit:typecheck_nodeclarations_js failed to build

remote spawn failed: UNIMPLEMENTED: Failed to route action: Failed to analyze initial size class: Failed to read previous execution stats for reduced action digest "1-68a38e29f00de7b98b884bf830d099f948fd994b7d2e3a02a75ce21f53b04176-232-": Failed to read mutable Protobuf message with digest "1-68a38e29f00de7b98b884bf830d099f948fd994b7d2e3a02a75ce21f53b04176-232-": Shard 1: unknown service buildbarn.iscc.InitialSizeClassCache

remote spawn failed: UNIMPLEMENTED: Failed to route action: Failed to analyze initial size class: Failed to read previous execution stats for reduced action digest "1-f29da188f160329d6345dfbcadd05f219075932fb9be14dca3fd0612c3a489b8-232-": Failed to read mutable Protobuf message with digest "1-f29da188f160329d6345dfbcadd05f219075932fb9be14dca3fd0612c3a489b8-232-": Shard 2: unknown service buildbarn.iscc.InitialSizeClassCache

124 other actions failed to build.

💡 To reproduce the build failures, run

bazel build --output_groups=+typecheck --output_groups=+types //examples/transpiler:babel //examples/lib_nocompile_linked:lib //examples/no_emit:typecheck_nodeclarations_js

---

Buildifier      Format

[Mivr]

After some discussions with @jbedard, I tested if the exclude is still needed at all for several parameters.
The tests made are as follows:

root_dir parameter testing (Latest rules_ts + default TS and node version)

root_dir	tsconfig rootDir	tsconfig exclude	Result
.	undefined	undefined	BUILD PASSED
./	undefined	undefined	BUILD PASSED
./src	undefined	undefined	BUILD FAILED - cannot find outputs
./src	undefined	[]	BUILD FAILED - cannot find outputs
./src	src	undefined	BUILD FAILED - cannot find outputs
./src	./src	undefined	BUILD FAILED - cannot find outputs
src	src	[]	BUILD PASSED
src	src	undefined	BUILD PASSED
src	./src	undefined	BUILD PASSED
src	undefined	undefined	BUILD PASSED
src	undefined	[]	BUILD PASSED

out_dir parameter testing (Latest rules_ts + default TS and node version)

out_dir	tsconfig outDir	tsconfig exclude	Result
out	Undefined	Undefined	BUILD PASSED
out	out	Undefined	BUILD PASSED
out	./out	Undefined	BUILD PASSED
Undefined	./out	Undefined	BUILD FAILED - cannot find outputs
Undefined	./out	[]	BUILD FAILED - cannot find outputs
Undefined	out	Undefined	BUILD FAILED - cannot find outputs
Undefined	out	[]	BUILD FAILED - cannot find outputs
.	Undefined	Undefined	BUILD PASSED
./	Undefined	Undefined	BUILD FAILED - ./ messes up outputs paths
./	Undefined	[]	BUILD FAILED - ./ messes up outputs paths
./out	Undefined	Undefined	BUILD FAILED - ./ messes up outputs paths

declaration_dir parameter testing declaration=True (Latest rules_ts + default TS and node version)

declaration_dir	tsconfig declarationDir	tsconfig exclude	Result
"dec"	"dec"	Undefined	BUILD PASSED
"dec"	Undefined	Undefined	BUILD FAILED - cannot find output declarations
Undefined	"dec"	Undefined	BUILD FAILED - cannot find output declarations

All tests were made before the changes in this branch. No tests show the need for exclude to be added at this point.

Is there a test case that still fails with the latest rules_ts?

And should we make these errors more friendly?
@jbedard

[aspect-workflows]

Test

All tests were cache hits

153 tests (100.0%) were fully cached saving 10s.

---

Buildifier      Format