feat: validate tsconfig outDir vs ts_project(out_dir)

examples/declaration_dir/tsconfig.json

@@ -2,6 +2,8 @@
     "compilerOptions": {
         "sourceMap": true,
         "declaration": true,
-        "declarationMap": true
-    }
+        "declarationMap": true,
+        "declarationDir": "out/types"
+    },
+    "exclude": []
 }

examples/out_dir/BUILD.bazel

@@ -29,7 +29,6 @@ ts_project(
     declaration_dir = "decl_map",
     declaration_map = True,
     out_dir = "declaration_dir",
-    tsconfig = {},
 )
 
 build_test(

examples/out_dir/tsconfig.json

@@ -0,0 +1,7 @@
+{
+    "compilerOptions": {
+        "declaration": true,
+        "declarationMap": true,
+        "declarationDir": "decl_map"
+    }
+}

examples/root_dir/BUILD.bazel

@@ -34,6 +34,7 @@ ts_project(
         "compilerOptions": {
             "rootDir": "subdir",
         },
+        "exclude": [],
     },
 )
 

examples/root_dir/tsconfig.json

@@ -1 +1,3 @@
-{}
+{
+    "exclude": []
+}

ts/private/ts_project.bzl

@@ -126,9 +126,6 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
     common_args.extend(ctx.attr.args)
 
     if (ctx.attr.out_dir and ctx.attr.out_dir != ".") or ctx.attr.root_dir:
-        # TODO: add validation that excludes is non-empty in this case, as passing the --outDir or --declarationDir flag
-        # to TypeScript causes it to set a default for excludes such that it won't find our sources that were copied-to-bin.
-        # See https://github.com/microsoft/TypeScript/issues/59036 and https://github.com/aspect-build/rules_ts/issues/644
         common_args.extend([
             "--outDir",
             _lib.join(ctx.label.workspace_root, ctx.label.package, ctx.attr.out_dir),

ts/private/ts_project_options_validator.js

@@ -142,6 +142,15 @@ function main(_a) {
             }
         }
     }
+
+    function check_exclude_and_rootDir() {
+        if (config.exclude === undefined && attrs['root_dir'] !== undefined && attrs['root_dir'] !== '') {
+            console.error('tsconfig validation failed: when root_dir is set, exclude must also be set. See: https://github.com/aspect-build/rules_ts/issues/644 for more details.')
+
+            throw new Error('tsconfig validation failed: when root_dir is set, exclude must also be set.')
+        }
+    }
+
     if (options.preserveSymlinks) {
         console.error(
             'ERROR: ts_project rule ' +
@@ -163,8 +172,10 @@ function main(_a) {
     check('declaration')
     check('incremental')
     check('tsBuildInfoFile', 'ts_build_info_file')
+    check('declarationDir', 'declaration_dir')
     check_nocheck()
     check_preserve_jsx()
+    check_exclude_and_rootDir()
     if (failures.length > 0) {
         console.error(
             'ERROR: ts_project rule ' +
@@ -201,6 +212,8 @@ function main(_a) {
             attrs.declaration +
             '\n// declaration_map:       ' +
             attrs.declaration_map +
+            '\n// declaration_dir:       ' +
+            attrs.declaration_dir +
             '\n// incremental:           ' +
             attrs.incremental +
             '\n// source_map:            ' +

ts/private/ts_validate_options.bzl

@@ -27,7 +27,9 @@ def _validate_action(ctx, tsconfig_inputs):
     config = struct(
         allow_js = ctx.attr.allow_js,
         declaration = ctx.attr.declaration,
+        declaration_dir = ctx.attr.declaration_dir,
         declaration_map = ctx.attr.declaration_map,
+        root_dir = ctx.attr.root_dir,
         preserve_jsx = ctx.attr.preserve_jsx,
         composite = ctx.attr.composite,
         no_emit = ctx.attr.no_emit,

ts/test/BUILD.bazel

@@ -25,6 +25,7 @@ ts_project(
             "declaration": True,
             "sourceMap": True,
         },
+        "exclude": [],
     },
 )