-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Grid from ontology to a data structure in core.py
#876
Conversation
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
==========================================
+ Coverage 80.84% 80.85% +0.01%
==========================================
Files 254 254
Lines 19444 19460 +16
==========================================
+ Hits 15719 15734 +15
- Misses 3725 3726 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
core.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments on this. Btw, where would the functionality: grid as index
for fast overlap computation be implemented? I think that's the actual reason of using grid.
…w array to improve efficiency
This PR fixes #817.
Description of changes
Grids
->Grid
and move it tocore.py
as a data structure rather than an ontologyPossible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Describe what test cases are included for the PR.