fix: respect isEncrypted:false if supplied in notify: command, and ensure the correct value is always transmitted onwards #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se if supplied in the command
…Encrypted value in notify: commands to be issued to another atServer
gkc
commented
Jul 22, 2024
| String? isEncryptedStr = | ||
| (atNotification.atMetadata!.isEncrypted ?? false) ? 'true' : 'false'; | ||
| commandBody = '${AtConstants.isEncrypted}:$isEncryptedStr:$commandBody'; | ||
|
|
There was a problem hiding this comment.
The above change is to ensure that the isEncrypted value in the notification's metadata is always passed on to the next atServer. Previously it was only passed on if the value was true
|
Converted to draft as I need to add some unit tests to ensure this doesn't regress in the future |
…ed` and mark `@visibleForTesting`
@sitaram-kalluri Have added some unit tests. Please review when you have a moment, thank you. |
sitaram-kalluri
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
fix: respect isEncrypted:false if supplied in notify: command, and ensure the correct value is always transmitted onwards
Addresses at_server parts of #1944
- How I did it
See commits
- How to verify it