Skip to content

Node peering rework #459

Node peering rework

Node peering rework #459

Triggered via pull request October 22, 2023 19:57
Status Failure
Total duration 34s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 4 warnings
lint: testclients/erroring.go#L1
: # github.com/attestantio/go-eth2-client/testclients
lint: testclients/erroring.go#L564
undefined: apiv1.Peers
lint: testclients/sleepy.go#L430
undefined: apiv1.Peers (typecheck)
lint: api/v1/peers.go#L10
Comment should end in a period (godot)
lint: api/v1/peers.go#L27
Comment should end in a period (godot)
lint: api/v1/peers.go#L30
Comment should end in a period (godot)
lint: http/nodepeers.go#L16
Consider pre-allocating `additionalFields` (prealloc)
lint: api/v1/peers.go#L36
S1002: should omit comparison to bool constant, can be simplified to `!exists` (gosimple)
lint: api/v1/peers.go#L40
S1002: should omit comparison to bool constant, can be simplified to `!exists` (gosimple)
lint: api/v1/peers.go#L60
S1002: should omit comparison to bool constant, can be simplified to `!ok` (gosimple)
lint: api/v1/peers.go#L75
receiver-naming: receiver name e should be consistent with previous receiver name p for Peer (revive)
lint: api/v1/peers.go#L37
errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)
lint: api/v1/peers.go#L41
errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)
lint: api/v1/peers.go#L61
errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)