ISSUE-598 # remove maven-compiler warnings with target Java 17 (JDK8 Compatible) #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WARNING] /home/alois/zerocode/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java:[102,62] non-varargs call of varargs method with inexact argument type for last parameter; cast to java.lang.Class<?> for a varargs call cast to java.lang.Class<?>[] for a non-varargs call and to suppress this warning [WARNING] /home/alois/zerocode/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java:[103,50] non-varargs call of varargs method with inexact argument type for last parameter; cast to java.lang.Object for a varargs call cast to java.lang.Object[] for a non-varargs call and to suppress this warning WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[21,39] Integer(java.lang.String) in java.lang.Integer has been deprecated and marked for removal [WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[21,57] Long(java.lang.String) in java.lang.Long has been deprecated and marked for removal [WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[22,39] Integer(java.lang.String) in java.lang.Integer has been deprecated and marked for removal [WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[22,57] Double(java.lang.String) in java.lang.Double has been deprecated and marked for removal [WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/runner/ZeroCodeUnitRuntimeAnnoTest.java:[57,78] non-varargs call of varargs method with inexact argument type for last parameter; cast to java.lang.Class<?> for a varargs call cast to java.lang.Class<?>[] for a non-varargs call and to suppress this warning [WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/executor/javaapi/JavaMethodExecutorImplTest.java:[90,83] non-varargs call of varargs method with inexact argument type for last parameter; cast to java.lang.Object for a varargs call cast to java.lang.Object[] for a non-varargs call and to suppress this warning
|
@authorjapps @nirmalchandra This PR could be merged into master. It is fully compatible with JDK8. |
|
CI Passed 🟢 as on : |
authorjapps
approved these changes
Feb 28, 2024
authorjapps
changed the title
|
@baulea , just checking why this PR name has "Java 17" ? If not needed, can you remove "17" from the PR name? |
|
I am slightly late, already merged :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove maven-compiler warnings with target Java 17 (JDK8 Compatible)
PR Branch
pull request
Motivation and Context
#598
Checklist:
Unit tests added
Integration tests added
Test names are meaningful
Feature manually tested
Branch build passed
No 'package.*' in the imports
Relevant Wiki page updated with clear instruction for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?