Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(make-sure-label-is-present): new workflow #301

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 12, 2024

Description

Situation with prevent-no-label-execution

  • Right now, if we add multiple labels to a PR, only one of them works.
  • This action currently checks only if the newly added label is the correct one.
  • But it should instead, check if the required label is in the labels list.

New reusable workflow: make-sure-label-is-present

  • It is much simpler.
  • Supports multiple labels.

Tests performed

Being tested with:

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx self-assigned this Jun 12, 2024
@xmfcx xmfcx force-pushed the feat/support-multiple-labels branch from 15fc5c9 to 771cefc Compare June 12, 2024 14:14
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

result

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

fix var

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

toJson

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

if space, noJson

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

test test-label

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

test

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

test

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

as it is

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the feat/support-multiple-labels branch from c44d513 to ffb4973 Compare June 12, 2024 15:13
M. Fatih Cırıt and others added 3 commits June 12, 2024 18:44
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx changed the title feat(prevent-no-label-execution): support multiple labels feat(make-sure-label-is-present): new workflow Jun 13, 2024
@xmfcx xmfcx marked this pull request as ready for review June 13, 2024 15:27
@xmfcx xmfcx merged commit 92b8188 into main Jun 13, 2024
15 of 16 checks passed
@xmfcx xmfcx deleted the feat/support-multiple-labels branch June 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants