New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/programs] migrate wasm runtime to wasmtime and refactor for VM integration #477

Merged

patrick-ogrady merged 49 commits into main from wasmtime

Oct 6, 2023

Contributor

hexfusion commented Sep 18, 2023 •

edited

Loading

This PR replaces wazero with wasmtime for the runtime engine.

TODO

Replace and extend meter test
Add support for precompiling wasm and bench
Update removed examples to work with new runtime
Remove Wasi preview support
Improve UX to only require unsigned ints similar to wazero

hexfusion force-pushed the wasmtime branch 2 times, most recently from b5684c8 to e43edfb Compare

September 20, 2023 02:15

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/imports/balance/balance.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/storage/storage.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/storage/storage.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/storage/storage.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/token.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/imports/hashmap/hashmap.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/imports/program/program.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/storage/storage.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/token.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/token_test.go Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/token_test.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/token_test.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/config.go Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/config.go Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/dependencies.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/runtime.go Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/runtime.go Outdated Show resolved Hide resolved

hexfusion added 11 commits

October 3, 2023 08:56


          [x/programs] migrate to wasm runtime to wasmtime

f23db1f

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Implement memory with tests

3ebbd38

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Add guest import examples

8e01086

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Add vm/storage examples

7cec29b

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Remove storage mocks

eb2c03f

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Remove hard coded guest imports

8ed6774

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Update token example to use new runtime

c7a8a34

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Implement guest export client

c76d204

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Add config builder

2303f5c

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          React to new implementations

2b6ce89

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Implement meter

7cf7f75

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/counter_test.go Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/imports/program/program.go

+              	}
+              	// stop the runtime to prevent further execution
+              	rt.Stop()

Contributor

patrick-ogrady Oct 5, 2023

❤️

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/imports/pstate/pstate.go Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/storage/storage.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/examples/util.go

+              	"github.com/ava-labs/hypersdk/x/programs/runtime"
+              )
+              func newKeyPtr(ctx context.Context, key ed25519.PublicKey, runtime runtime.Runtime) (uint64, error) {

Contributor

patrick-ogrady Oct 5, 2023 •

edited

Loading

We'll turn ed25519.PublicKey into a new type soon but good enough for now (will become "short bytes")

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/config.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/config.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/config.go Outdated Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/runtime.go Show resolved Hide resolved

patrick-ogrady reviewed

View reviewed changes

x/programs/runtime/config.go Outdated Show resolved Hide resolved

richardpringle previously approved these changes

View reviewed changes

hexfusion added 4 commits

October 6, 2023 10:10


          Cleanup storage

fa1b0ac

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Define defaults for all configs

e045b56

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Remove unused file

7fdaff5

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>


          Document opt-level flag for release profile

8eb9122

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>

hexfusion dismissed richardpringle’s stale review via

8eb9122

October 6, 2023 14:13

hexfusion added 2 commits

October 6, 2023 10:13


          Merge branch 'main' into wasmtime

574fbbd


          Remove todo

14857d7

Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>

hexfusion added run release and removed run release labels

patrick-ogrady approved these changes

View reviewed changes

patrick-ogrady merged commit 8ecd682 into main

34 of 45 checks passed

patrick-ogrady deleted the wasmtime branch

October 6, 2023 21:37

hexfusion changed the title ~~[x/programs] migrate to wasm runtime to wasmtime and refactor for VM integration~~ [x/programs] migrate wasm runtime to wasmtime and refactor for VM integration

This was referenced Oct 31, 2023

[x/programs] migrate runtime to wasmtime #466

Closed

[x/programs] add support for metering opscode whitelist. #401

Closed

[x/programs] Generic storage interface in runtime #454

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels