Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular load.properties prevention #177

Open
agentgt opened this issue Sep 24, 2024 · 1 comment · May be fixed by #178
Open

Circular load.properties prevention #177

agentgt opened this issue Sep 24, 2024 · 1 comment · May be fixed by #178
Assignees
@SentryMan
Milestone
4.1

Comments

@agentgt
Copy link

agentgt commented Sep 24, 2024

We should probably handle this case:

#a.properties
load.properties=b.properties
#b.properties
load.properties=a.properties
@agentgt
Copy link
Author

agentgt commented Sep 24, 2024

While the obvious might be to just keep track of resource names in a Set I still recommend some sort of maximum depth of load.properties as a failsafe.

@SentryMan SentryMan linked a pull request Sep 25, 2024 that will close this issue
Open
@agentgt agentgt mentioned this issue Oct 2, 2024
Draft
@SentryMan SentryMan self-assigned this Oct 28, 2024
@SentryMan SentryMan added this to the 4.1 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SentryMan SentryMan

Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Prevent circular load.properties SentryMan/avaje-config
2 participants
@agentgt @SentryMan