Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent circular load.properties #178

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Prevent circular load.properties #178

wants to merge 13 commits into from

Conversation

SentryMan
Copy link
Collaborator

fixes #177

@SentryMan SentryMan self-assigned this Sep 25, 2024
agentgt
agentgt reviewed Sep 25, 2024
View reviewed changes
Copy link

@agentgt agentgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simple integer instead of a set of visited resources is safer solution that will not break backward compat.

avaje-config/src/main/java/io/avaje/config/InitialLoader.java Outdated Show resolved Hide resolved
@SentryMan SentryMan added the enhancement New feature or request label Sep 25, 2024
@SentryMan SentryMan added this to the 4.1 milestone Sep 25, 2024
@agentgt
Copy link

agentgt commented Sep 26, 2024

LGTM. I think we get this in before #176

@SentryMan SentryMan changed the title Use a set to prevent circular load.properties Prevent circular load.properties Oct 1, 2024
@SentryMan
Copy link
Collaborator Author

@rbygrave please review when you get time

@SentryMan SentryMan mentioned this pull request Oct 28, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agentgt agentgt agentgt left review comments

@rbygrave rbygrave Awaiting requested review from rbygrave

@rob-bygrave rob-bygrave Awaiting requested review from rob-bygrave

At least 1 approving review is required to merge this pull request.

Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Circular load.properties prevention
3 participants
@SentryMan @agentgt @rob-bygrave