Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ServiceLoader for yaml #87

Closed
wants to merge 4 commits into from
Closed

Use ServiceLoader for yaml #87

wants to merge 4 commits into from

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jul 28, 2023

now people can plug their own yaml parsers.
fixes part of #41

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 28, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@SentryMan SentryMan marked this pull request as draft July 28, 2023 15:46
@SentryMan
Copy link
Collaborator Author

hmm

@SentryMan SentryMan marked this pull request as ready for review July 28, 2023 16:08
@SentryMan
Copy link
Collaborator Author

SentryMan commented Jul 28, 2023

perhaps I've become too comfortable with circles(this time I just didn't feel like rewriting all the tests). But this'll work to extract the yml out of the config module so it can be excluded via maven.

@rob-bygrave
Copy link
Contributor

I don't think this change is justified. The premise is the YamlSimpleLoader is large enough to justify removing it out into a separate module.

It's 300 lines, I don't think this justifies pulling it out into a separate module etc.

@SentryMan
Copy link
Collaborator Author

It saves like 10kb if we take it out yeah

@SentryMan SentryMan closed this Jul 31, 2023
@SentryMan SentryMan deleted the yml branch July 31, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants