fix(stepfunctions): the retry field in CustomState is not iterable #29403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
repeat-contributor
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
approved these changes
Mar 9, 2024
packages/aws-cdk-lib/aws-stepfunctions/lib/states/custom-state.ts
Outdated
Show resolved
Hide resolved
aws-cdk-automation
added
pr/needs-maintainer-review
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
aaythapa
previously approved these changes
Mar 12, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aaythapa
approved these changes
Mar 12, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 task
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #29274
Reason for this change
CDK users were unable to specify their retry strategy if it was specified inline in their ASL state machine definition
Description of changes
Checks if the state definition has an inline retry policy defined. If it does, add it to the existing strategy defined using
addRetry(if there is one defined, this is where it was failing before)Description of how you validated changes
Added unit and integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license