update _RUNTIME_GLIBC mapping to support newer python versions #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildaniel
approved these changes
May 13, 2024
hnnasit
reviewed
May 13, 2024
| @@ -203,6 +203,9 @@ class DependencyBuilder(object): | |||
| "cp37m": (2, 17), | |||
| "cp38": (2, 26), | |||
| "cp39": (2, 26), | |||
| "cp310": (2, 26), | |||
There was a problem hiding this comment.
Have we verified installing llama-cpp-python==0.2.55 works on python 310/311/12 after this change? I recall seeing the same error even after making this change.
There was a problem hiding this comment.
There was an error if this particular library is not built in container, as the library provides only the source tar so it must be built from source.
It built fine in container-build without any issue
hnnasit
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#624
Description of changes:
Update python glibc mapping to support newer versions of python for the scenario that a package needs to be built from source (e.g. llama-cpp)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.