Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update _RUNTIME_GLIBC mapping to support newer python versions #648

Merged
merged 1 commit into from
May 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions aws_lambda_builders/workflows/python_pip/packager.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,9 @@ class DependencyBuilder(object):
"cp37m": (2, 17),
"cp38": (2, 26),
"cp39": (2, 26),
"cp310": (2, 26),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we verified installing llama-cpp-python==0.2.55 works on python 310/311/12 after this change? I recall seeing the same error even after making this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an error if this particular library is not built in container, as the library provides only the source tar so it must be built from source.

It built fine in container-build without any issue

"cp311": (2, 26),
"cp312": (2, 26),
}
# Fallback version if we're on an unknown python version
# not in _RUNTIME_GLIBC.
Expand Down
Loading