Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Don't execute change set instead of waiting for prompt #5730

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Aug 8, 2023

Which issue(s) does this change fix?

None

Why is this change necessary?

The integration test was stuck on Linux machines due to the process waiting for a prompt that never appears when running the deploy commands as a persistent command.

How does it address the issue?

Uses the existing --no-execute-changeset flag to create a change set and exit, instead of waiting for the prompt and killing the process.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@moelasmar moelasmar self-requested a review August 8, 2023 20:22
@lucashuy lucashuy marked this pull request as ready for review August 8, 2023 20:34
@lucashuy lucashuy requested a review from a team as a code owner August 8, 2023 20:34
@lucashuy lucashuy requested a review from mildaniel August 8, 2023 20:34
@hnnasit hnnasit enabled auto-merge August 8, 2023 20:47
@hnnasit hnnasit added this pull request to the merge queue Aug 8, 2023
Merged via the queue into aws:develop with commit e79955e Aug 8, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants