Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Don't execute change set instead of waiting for prompt #5730

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix(test): Don't execute change set instead of waiting for prompt #5730

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4873e94
Don't execute change set instead of waiting for input
lucashuy Aug 8, 2023
0a9376d
Merge branch 'develop' into fix_review_in_progress_test
lucashuy Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions tests/integration/delete/test_delete_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,17 +479,12 @@ def test_delete_stack_review_in_progress(self):
s3_bucket=self.bucket_name,
s3_prefix=self.s3_prefix,
force_upload=True,
no_execute_changeset=False,
confirm_changeset=True,
no_execute_changeset=True,
region=self._session.region_name,
)

# run deploy command and wait for it to ask about change set
deploy_process = start_persistent_process(deploy_command)
read_until_string(deploy_process, "Deploy this changeset? [y/N]:")

# kill the deploy process so that the stack is stuck in REVIEW_IN_PROGRESS
kill_process(deploy_process)
# run deploy command but don't execute changeset to force it in REVIEW_IN_PROGRESS
run_command(deploy_command)

delete_command = self.get_delete_command_list(
stack_name=stack_name, region=self._session.region_name, no_prompts=True
Expand Down
Loading