Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1-30 tests using wrong templates/kube version #8224

Merged
merged 2 commits into from
May 28, 2024

Conversation

rahulbabu95
Copy link
Member

@rahulbabu95 rahulbabu95 commented May 28, 2024

Fix 1.30 tests that either use the wrong templates or the wrong Kubernetes version. Also skip 1.30 packages tests for providers until we bump all the packages to latest upstream version that supports 1.30.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ests for 1.30

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 28, 2024
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (0e112c0) to head (bff6d4f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8224   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files         577      577           
  Lines       35944    35944           
=======================================
  Hits        26391    26391           
  Misses       7884     7884           
  Partials     1669     1669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@d8660091
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 7abe87c into aws:main May 28, 2024
10 checks passed
@rahulbabu95 rahulbabu95 deleted the some-130-fixes branch May 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants