Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking packages commands as deprecated #8240

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Jun 2, 2024

Issue https://github.com/aws/eks-anywhere-internal/issues/2270

Description of changes:
As described in the issue we want to mark packages commands as deprecated. For release v0.20.0 the commands are still present and in the next release we would remove the commands themselves.

Documentation added/planned:
Will update the docs and call out that these commands are not supported.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2024
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (560fbf4) to head (e227afc).

Current head e227afc differs from pull request most recent head acd13e3

Please upload reports for the commit acd13e3 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8240   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files         578      578           
  Lines       36054    36054           
=======================================
  Hits        26473    26473           
  Misses       7904     7904           
  Partials     1677     1677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokearu pokearu force-pushed the mark-cmd-deprecated branch from cf58ec7 to 980a3b4 Compare June 9, 2024 12:22
@eks-distro-bot
Copy link
Collaborator

@pokearu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-release-tooling-test-presubmit e227afc link true /test eks-anywhere-release-tooling-test-presubmit
eks-anywhere-release-tooling-presubmit e227afc link true /test eks-anywhere-release-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhay-krishna
Copy link
Member

/lgtm
/approve

@@ -55,6 +55,7 @@ var upgradePackagesCommand = &cobra.Command{
}
return nil
},
Deprecated: "refer `https://anywhere.eks.amazonaws.com/docs/packages/packagebundles` for upgrading",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deprecated: "refer `https://anywhere.eks.amazonaws.com/docs/packages/packagebundles` for upgrading",
Deprecated: "refer to `https://anywhere.eks.amazonaws.com/docs/packages/packagebundles` for upgrading",

@pokearu pokearu force-pushed the mark-cmd-deprecated branch from d6d8e89 to acd13e3 Compare June 10, 2024 16:19
@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pokearu pokearu merged commit e0400fa into aws:main Jun 10, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants