-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marking packages commands as deprecated #8240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8240 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 578 578
Lines 36054 36054
=======================================
Hits 26473 26473
Misses 7904 7904
Partials 1677 1677 ☔ View full report in Codecov by Sentry. |
cf58ec7
to
980a3b4
Compare
@pokearu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
@@ -55,6 +55,7 @@ var upgradePackagesCommand = &cobra.Command{ | |||
} | |||
return nil | |||
}, | |||
Deprecated: "refer `https://anywhere.eks.amazonaws.com/docs/packages/packagebundles` for upgrading", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated: "refer `https://anywhere.eks.amazonaws.com/docs/packages/packagebundles` for upgrading", | |
Deprecated: "refer to `https://anywhere.eks.amazonaws.com/docs/packages/packagebundles` for upgrading", |
e227afc
to
d6d8e89
Compare
d6d8e89
to
acd13e3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue https://github.com/aws/eks-anywhere-internal/issues/2270
Description of changes:
As described in the issue we want to mark packages commands as deprecated. For release v0.20.0 the commands are still present and in the next release we would remove the commands themselves.
Documentation added/planned:
Will update the docs and call out that these commands are not supported.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.