Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript build lib target #715

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

Zenithar
Copy link
Contributor

@Zenithar Zenithar commented Nov 8, 2024

Context

We are using this jupyter component in our tool - https://kubehound.io.

The UI setup, based on Jupyterlab, runs the command npm run build:lib and raises typescript issues, preventing the installation of version 4.6.1.

$ npx tsc                                                                                                                                                               
node_modules/@rjsf/utils/lib/getDateElementProps.d.ts:1:15 - error TS1005: ',' expected.

1 import { type DateObject } from './types';
                ~~~~~~~~~~

node_modules/@rjsf/utils/lib/index.d.ts:17:36 - error TS1005: ',' expected.

17 import getDateElementProps, { type DateElementFormat } from './getDateElementProps';
                                      ~~~~~~~~~~~~~~~~~


Found 2 errors.

I updated the typescript to the latest version 5.6.3.

With the last version of typescript, I got issues with the types.ts file

$ npx tsc
src/types.ts:37:24 - error TS2300: Duplicate identifier 'id'.

37   constructor(readonly id: string) {
                          ~~

src/types.ts:91:14 - error TS2300: Duplicate identifier 'from'.

91     readonly from: string,
                ~~~~

src/types.ts:92:14 - error TS2300: Duplicate identifier 'to'.

92     readonly to: string,
                ~~

src/types.ts:93:14 - error TS2300: Duplicate identifier 'id'.

93     readonly id: string,
                ~~

src/types.ts:187:24 - error TS2300: Duplicate identifier 'id'.

187   constructor(readonly id: string) {
                           ~~


Found 5 errors in the same file, starting at: src/types.ts:37

As soon. as the types.ts everything can be installed correctly.

Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zenithar !

@michaelnchin michaelnchin merged commit de7b926 into aws:main Nov 9, 2024
3 checks passed
@Zenithar Zenithar deleted the fix_typescript_build_lib_target branch November 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants