Add secrets-common for shared secrets #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a shared secrets file used across all destinations. Useful for things Github tokens or registry passwords. The secrets are added to a new file called `secrets-common` to highlight they are shared, and to avoid acciedentally inheriting a secret from the `secrets` file to `secrets.destination`.
|
cc @mhenrixon |
Sija
reviewed
Sep 11, 2024
|
|
||
| Kamal::Secrets::Dotenv::InlineCommandSubstitution.install! | ||
|
|
||
| def initialize(destination: nil) | ||
| @secrets_file = [ *(".kamal/secrets.#{destination}" if destination), ".kamal/secrets" ].find { |f| File.exist?(f) } | ||
| @secrets_files = \ | ||
| [ ".kamal/secrets-common", ".kamal/secrets#{(".#{destination}" if destination)}" ].select { |f| File.exist?(f) } |
There was a problem hiding this comment.
Stylistic suggestion: secrets.common would be more inline with the rest of the destination file naming format.
There was a problem hiding this comment.
secrets.common would clash with a destination called common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a shared secrets file used across all destinations. Useful for things Github tokens or registry passwords.
The secrets are added to a new file called
secrets-commonto highlight they are shared, and to avoid accidentally inheriting a secret from thesecretsfile tosecrets.destination.