19828 fixed broken unit tests (warnings + services) #2526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulGarewal
commented
Mar 18, 2024
| ("SUCCESS", "GP", EntityRole.RoleTypes.partner, 1, 1, None, None, "BEN", "BC000008"), | ||
| ("FAIL_PARTNER_REQUIRED", "GP", EntityRole.RoleTypes.partner, 0, 0, "NO_PARTNER", "2 partners are required.", "BEN", "BC000009"), | ||
| ("FAIL_PARTNER_REQUIRED", "GP", EntityRole.RoleTypes.partner, 1, 0, "NO_PARTNER", "2 partners are required.", "BEN", "BC0000010"), | ||
| ("FAIL_PARTNER_REQUIRED", "GP", EntityRole.RoleTypes.partner, 0, 1, "NO_PARTNER", "2 partners are required.", "BEN", "BC0000011") | ||
| ], | ||
| ) | ||
| def test_check_firm_parties( |
There was a problem hiding this comment.
tests pass here except for FAIL_PROPRIETOR_REQUIRED-SP-proprietor "BC0000005".
PaulGarewal
commented
Mar 18, 2024
| ), | ||
| ], | ||
| ) | ||
| def test_check_firm_party(session, test_name, legal_type, role, party_type, expected_code, expected_msg): | ||
| def test_check_firm_party(session, test_name, legal_type, role, party_type, expected_code, expected_msg, owner_legal_type, owner_identifier): |
There was a problem hiding this comment.
test cases here fail due to NO_BUSINESS_PARTY_MAILING_ADDRESS warning messages
* amalgamation table change * clean up
* Get unit tests running * Update pyproject.toml * Undo format changes to common migrations * Export BusinessCommon from common models
* 20165 added entity_type changes to alternate name * typo fix
* AmalTED pdf * Amalgamating pdf * remove Dissolution/Restoration Information section * fix lint error * lint with flake8 * lint
* 19154 Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix linting Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * update error messages Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> --------- Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
* fix spacing and TING * retrive to the previous output
* added first draft of outputs * testing adding folder * added draft amalgamation outputs * cleaned up application syntax * fixed typo * added data formatting and noa * added dates for certificate of amalgamation * repeated effective_date_time in business details for amalgamation application * fixed lint issue * fixed typo * fixed notice of articles and removed amalgamation/nameRequest * removed amalgamations.html from business-summary.html * reestablished amalgamations.html * removed completingParty from amalgamations and added from incorp * removed incorp/bencompany from noa in amalgamationApp
* 18803 add amalgamation email * fix small * fix lint issue * fix small * fix the get_filing parts * fix small * fix the test * fix lint issue * fix lint issue * update version
…) to business(es) (bcgov#2414)
…ran black formatter
* 18750-put-back-on-rules * Updated authz
…esses data (bcgov#2515) cherry pick fixes
* fixed small issue in authz after sync with main * fixed if statement order
* 20016 - alternate name update * 20016 - alternate name update report.py * 20016 - fix formatting issues * 20016 - sort imports * 20016 - remove unused imports * 20016 - add logic to use start date for alternate name entities * 20016 - update bnmove endpoint to work with alternate name * 20016 - update unit tests for bnmove * 20016 - update test case name * 20016 - update logic to return alternate name
…te name table associations for non-SP businesses in data script (bcgov#2541)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#19828
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).