Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19828 fixed broken unit tests (warnings + services) #2526

Commits on Mar 18, 2024

  1. Configuration menu
    Copy the full SHA
    485b0ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    26ea94e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    7405252 View commit details
    Browse the repository at this point in the history
  2. 20212 - amalgamation table change (bcgov#2527)

    * amalgamation table change
    
    * clean up
    tshyun24 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e62845d View commit details
    Browse the repository at this point in the history
  3. oas3 for business

    thorwolpert authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9d77c74 View commit details
    Browse the repository at this point in the history
  4. 20320 Get entity-filer tests running (bcgov#2533)

    * Get unit tests running
    
    * Update pyproject.toml
    
    * Undo format changes to common migrations
    
    * Export BusinessCommon from common models
    leodube-aot authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cffb39e View commit details
    Browse the repository at this point in the history
  5. 20165 alternate name type changes (bcgov#2535)

    * 20165 added entity_type changes to alternate name
    
    * typo fix
    PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    dbe7330 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    76e13a5 View commit details
    Browse the repository at this point in the history
  7. 11550 - AmalgamaTING and TED Business Summary PDF (bcgov#2398)

    * AmalTED pdf
    
    * Amalgamating pdf
    
    * remove Dissolution/Restoration Information section
    
    * fix lint error
    
    * lint with flake8
    
    * lint
    tshyun24 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cd08ddf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8fc33f5 View commit details
    Browse the repository at this point in the history
  9. 19154 Update TING validation rules (bcgov#2403)

    * 19154
    
    Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
    
    * fix linting
    
    Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
    
    * update error messages
    
    Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
    
    ---------
    
    Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
    chenhongjing authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c0f4259 View commit details
    Browse the repository at this point in the history
  10. 11550 - fix spacing and TING (bcgov#2404)

    * fix spacing and TING
    
    * retrive to the previous output
    tshyun24 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    87546d5 View commit details
    Browse the repository at this point in the history
  11. 18802 amalgamation outputs (bcgov#2399)

    * added first draft of outputs
    
    * testing adding folder
    
    * added draft amalgamation outputs
    
    * cleaned up application syntax
    
    * fixed typo
    
    * added data formatting and noa
    
    * added dates for certificate of amalgamation
    
    * repeated effective_date_time in business details for amalgamation application
    
    * fixed lint issue
    
    * fixed typo
    
    * fixed notice of articles and removed amalgamation/nameRequest
    
    * removed amalgamations.html from business-summary.html
    
    * reestablished amalgamations.html
    
    * removed completingParty from amalgamations and added from incorp
    
    * removed incorp/bencompany from noa in amalgamationApp
    PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3065a26 View commit details
    Browse the repository at this point in the history
  12. 18803 Add amalgamation email (bcgov#2406)

    * 18803 add amalgamation email
    
    * fix small
    
    * fix lint issue
    
    * fix small
    
    * fix the get_filing parts
    
    * fix small
    
    * fix the test
    
    * fix lint issue
    
    * fix lint issue
    
    * update version
    kzdev420 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    be0fd17 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    33048ce View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    299c1e3 View commit details
    Browse the repository at this point in the history
  15. ran lint on legal api

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f339242 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3a11856 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    b51dc61 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    526ae8c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ecf98e5 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    a779951 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    2826970 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    568bf0f View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    2c57e03 View commit details
    Browse the repository at this point in the history
  24. 19433 amalgamation state filing fix (bcgov#2415) cherry pick fixes + …

    …ran black formatter
    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    24cbe74 View commit details
    Browse the repository at this point in the history
  25. Merge pull request bcgov#2410 from jamespaologarcia/19292-TING-amalga…

    …mation-alert
    
    19292-TING-amalgamation-alert-for-future-effective-dated
    jamespaologarcia authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1daeb74 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    9f8316f View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    fb48161 View commit details
    Browse the repository at this point in the history
  28. Merge pull request bcgov#2425 from stevenc987/main

    Names letters: Error noted on Expiring Soon letter#19142
    stevenc987 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1d7a8dc View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    71420d4 View commit details
    Browse the repository at this point in the history
  30. 19043 Validation for short form (bcgov#2428) cherry pick fixes + ran …

    …black + misc fixes
    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a526b37 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    c8d95d5 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    08284e1 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    0a10c01 View commit details
    Browse the repository at this point in the history
  34. update parties endpoint to include all ceased parties when param is g… (

    bcgov#2431)
    
    * update parties endpoint to include all ceased parties when param is given
    
    Signed-off-by: Kial Jinnah <kialj876@gmail.com>
    
    * lint fix
    
    Signed-off-by: Kial Jinnah <kialj876@gmail.com>
    
    ---------
    
    Signed-off-by: Kial Jinnah <kialj876@gmail.com>
    kialj876 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3f599be View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    7ed1d9b View commit details
    Browse the repository at this point in the history
  36. 19453 added legalName field to draft_results to link with auth-api (b…

    …cgov#2429)
    
    * 19453 added legalName field to draft_results to link with auth-api
    
    * fixed lint
    
    * removed amalgamation specify condition and updated unit test
    
    * added .get to legalName draftType
    PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    bc293bc View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    9408f6c View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    e3d1cda View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    0611120 View commit details
    Browse the repository at this point in the history
  40. fix key error (bcgov#2436)

    vysakh-menon-aot authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    df44ddb View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    61d8402 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    0f937de View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    c1c9759 View commit details
    Browse the repository at this point in the history
  44. 19405 Remove legal-api dependencies (bcgov#2444)

    * remove legal-api dependencies
    
    * fix lint issue
    kzdev420 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cab01e9 View commit details
    Browse the repository at this point in the history
  45. add missed dependency (bcgov#2447)

    kzdev420 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    722aaeb View commit details
    Browse the repository at this point in the history
  46. ran black on filer

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0b25192 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    0b50867 View commit details
    Browse the repository at this point in the history
  48. ran isort on legal api

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9aa41bf View commit details
    Browse the repository at this point in the history
  49. Fixed all kinds of lint errors

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0dd836c View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    b476f06 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    de5e17b View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    62a0694 View commit details
    Browse the repository at this point in the history
  53. fixed isort problems

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8cf9893 View commit details
    Browse the repository at this point in the history
  54. lint fixes on filer

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    18ca01b View commit details
    Browse the repository at this point in the history
  55. fixed flake8 problems

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    dc2cb45 View commit details
    Browse the repository at this point in the history
  56. fixed isort problem

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    23b5877 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    23cbfaa View commit details
    Browse the repository at this point in the history
  58. 19649 inherit legal name from primary or holding business (bcgov#2450)…

    … cherry pick fixes + linting
    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cef242a View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    970d454 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    19904aa View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    a922248 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    180a7e5 View commit details
    Browse the repository at this point in the history
  63. Fixed email content

    jamespaologarcia authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    32530ce View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    a9e50d0 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    9d6ec6f View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    69e0c47 View commit details
    Browse the repository at this point in the history
  67. Updated summary outputs

    jamespaologarcia authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3cd5768 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    41c8d86 View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    9d82642 View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    c34e25b View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    567124c View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    00d16a9 View commit details
    Browse the repository at this point in the history
  73. Merge pull request bcgov#2471 from jamespaologarcia/19885-incorrect-d…

    …ate-format-amalgamation-certificate
    
    19885-incorrect-amalgamation-date-format
    jamespaologarcia authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ad0e23c View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    87cb14f View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    d32fa5f View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    61ba240 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    716e75e View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    2865205 View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    a6d8807 View commit details
    Browse the repository at this point in the history
  80. fixed lint issues

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    54ebf36 View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    a8977dd View commit details
    Browse the repository at this point in the history
  82. 19865-disallow-ting-restorations (bcgov#2481)

    * 19865-disallow-ting-restorations
    
    * Added test case and updated the business_blocker_check
    
    * Fixed linting errors
    
    * Fixed unit test.
    jamespaologarcia authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c1bdd88 View commit details
    Browse the repository at this point in the history
  83. Configuration menu
    Copy the full SHA
    7f4c51e View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    0fb295b View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    af57010 View commit details
    Browse the repository at this point in the history
  86. Configuration menu
    Copy the full SHA
    182602f View commit details
    Browse the repository at this point in the history
  87. Configuration menu
    Copy the full SHA
    e3bea7b View commit details
    Browse the repository at this point in the history
  88. fix flake8 issue

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    436bdbb View commit details
    Browse the repository at this point in the history
  89. ran black again

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c5b0305 View commit details
    Browse the repository at this point in the history
  90. 18750-put-back-on-rules (bcgov#2498)

    * 18750-put-back-on-rules
    
    * Updated authz
    jamespaologarcia authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e64273a View commit details
    Browse the repository at this point in the history
  91. Configuration menu
    Copy the full SHA
    2fbbec9 View commit details
    Browse the repository at this point in the history
  92. Configuration menu
    Copy the full SHA
    edcd606 View commit details
    Browse the repository at this point in the history
  93. Configuration menu
    Copy the full SHA
    2c33ddf View commit details
    Browse the repository at this point in the history
  94. Configuration menu
    Copy the full SHA
    ad02fab View commit details
    Browse the repository at this point in the history
  95. 20179 admin dissolution - delete amalgamations and amalgamating_busin…

    …esses data (bcgov#2515) cherry pick fixes
    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cc4843d View commit details
    Browse the repository at this point in the history
  96. Configuration menu
    Copy the full SHA
    f606ca9 View commit details
    Browse the repository at this point in the history
  97. Configuration menu
    Copy the full SHA
    14662ce View commit details
    Browse the repository at this point in the history
  98. Configuration menu
    Copy the full SHA
    53c7041 View commit details
    Browse the repository at this point in the history
  99. Configuration menu
    Copy the full SHA
    4320a65 View commit details
    Browse the repository at this point in the history
  100. Configuration menu
    Copy the full SHA
    8f57913 View commit details
    Browse the repository at this point in the history
  101. Configuration menu
    Copy the full SHA
    f1cd19f View commit details
    Browse the repository at this point in the history
  102. Configuration menu
    Copy the full SHA
    a5bf2d0 View commit details
    Browse the repository at this point in the history
  103. Configuration menu
    Copy the full SHA
    79e1b11 View commit details
    Browse the repository at this point in the history
  104. fixed legal api lint

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a23aa53 View commit details
    Browse the repository at this point in the history
  105. Configuration menu
    Copy the full SHA
    6ccb16d View commit details
    Browse the repository at this point in the history
  106. fixed lint issues

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0dbf440 View commit details
    Browse the repository at this point in the history
  107. 19451 Fixed small issue in authz after sync with main (bcgov#2539)

    * fixed small issue in authz after sync with main
    
    * fixed if statement order
    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5135bbb View commit details
    Browse the repository at this point in the history
  108. 20016 - update missed alternate name instances (bcgov#2531)

    * 20016 - alternate name update
    
    * 20016 - alternate name update report.py
    
    * 20016 - fix formatting issues
    
    * 20016 - sort imports
    
    * 20016 - remove unused imports
    
    * 20016 - add logic to use start date for alternate name entities
    
    * 20016 - update bnmove endpoint to work with alternate name
    
    * 20016 - update unit tests for bnmove
    
    * 20016 - update test case name
    
    * 20016 - update logic to return alternate name
    ketaki-deodhar authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3fdc541 View commit details
    Browse the repository at this point in the history
  109. Reverted commented code for amalgamations and fixed incorrect alterna…

    …te name table associations for non-SP businesses in data script (bcgov#2541)
    argush3 authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6010bbc View commit details
    Browse the repository at this point in the history
  110. Configuration menu
    Copy the full SHA
    1591610 View commit details
    Browse the repository at this point in the history
  111. fixed poetry lock (bcgov#2545)

    JazzarKarim authored and PaulGarewal committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8442a0f View commit details
    Browse the repository at this point in the history
  112. Configuration menu
    Copy the full SHA
    8e47572 View commit details
    Browse the repository at this point in the history
  113. Configuration menu
    Copy the full SHA
    c053e3d View commit details
    Browse the repository at this point in the history