Task/tpi summarize hfi #3800
Merged
Task/tpi summarize hfi #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3800 +/- ##
==========================================
- Coverage 79.59% 79.31% -0.29%
==========================================
Files 294 295 +1
Lines 10823 10874 +51
Branches 518 518
==========================================
+ Hits 8615 8625 +10
- Misses 2064 2105 +41
Partials 144 144 ☔ View full report in Codecov by Sentry. |
dgboss
reviewed
Jul 25, 2024
dgboss
reviewed
Jul 25, 2024
dgboss
reviewed
Jul 25, 2024
dgboss
reviewed
Jul 25, 2024
dgboss
reviewed
Jul 25, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca>
Naming and abstraction boundaries could be improved I think, but short of recreating |
dgboss
reviewed
Jul 29, 2024
dgboss
reviewed
Jul 29, 2024
dgboss
reviewed
Jul 31, 2024
dgboss
reviewed
Jul 31, 2024
dgboss
approved these changes
Jul 31, 2024
dgboss
reviewed
Aug 7, 2024
dgboss
reviewed
Aug 7, 2024
dgboss
approved these changes
Aug 7, 2024
brettedw
reviewed
Aug 7, 2024
|
This was referenced Aug 9, 2024
Merged
conbrad
added a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca> Test suite for geospatial functions introduced in #3800
dgboss
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca> Summarizes advisory area based on TPI. Uses the snow-masked pmtiles hfi layer for the given date to mask contributing TPI pixels. After finding out the initial implementation uses up to 20GB of memory, commit ab72307 and onwards introduce a more memory optimized implementation. Basically all datasets are loaded from S3, but data is only read in and transformed a chunk at a time. This implementation stays under 4.5GB of memory usage.
dgboss
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca> Test suite for geospatial functions introduced in #3800
vanislekahuna
pushed a commit
to vanislekahuna/wps
that referenced
this pull request
Sep 19, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca> Summarizes advisory area based on TPI. Uses the snow-masked pmtiles hfi layer for the given date to mask contributing TPI pixels. After finding out the initial implementation uses up to 20GB of memory, commit bcgov@ab72307 and onwards introduce a more memory optimized implementation. Basically all datasets are loaded from S3, but data is only read in and transformed a chunk at a time. This implementation stays under 4.5GB of memory usage.
vanislekahuna
pushed a commit
to vanislekahuna/wps
that referenced
this pull request
Sep 19, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca> Test suite for geospatial functions introduced in bcgov#3800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarizes advisory area based on TPI. Uses the snow-masked pmtiles hfi layer for the given date to mask contributing TPI pixels.
After finding out the initial implementation uses up to 20GB of memory, commit ab72307 and onwards introduce a more memory optimized implementation. Basically all datasets are loaded from S3, but data is only read in and transformed a chunk at a time. This implementation stays under 4.5GB of memory usage.
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator