Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒 H-02 - Prevent Freezing of Funds in Factory Contracts #114

Merged
merged 5 commits into from
Aug 5, 2024

Merge pull request #115 from bcnmy/fix/security-h03

a1c968d
Select commit
Loading
Failed to load commit list.
Merged

🔒 H-02 - Prevent Freezing of Funds in Factory Contracts #114

Merge pull request #115 from bcnmy/fix/security-h03
a1c968d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 5, 2024 in 0s

71.17% (target 80.00%)

View this Pull Request on Codecov

71.17% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.17%. Comparing base (482e6cc) to head (a1c968d).

Files Patch % Lines
contracts/factory/NexusAccountFactory.sol 50.00% 1 Missing ⚠️
contracts/factory/RegistryFactory.sol 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           fix/security-h01     #114      +/-   ##
====================================================
- Coverage             72.18%   71.17%   -1.02%     
====================================================
  Files                    13       13              
  Lines                   676      680       +4     
  Branches                124      151      +27     
====================================================
- Hits                    488      484       -4     
- Misses                  186      196      +10     
+ Partials                  2        0       -2     
Files Coverage Δ
contracts/factory/BiconomyMetaFactory.sol 93.33% <100.00%> (ø)
contracts/factory/K1ValidatorFactory.sol 69.69% <100.00%> (+3.03%) ⬆️
contracts/utils/RegistryBootstrap.sol 100.00% <100.00%> (+8.69%) ⬆️
contracts/factory/NexusAccountFactory.sol 60.71% <50.00%> (-0.83%) ⬇️
contracts/factory/RegistryFactory.sol 61.81% <50.00%> (-0.45%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482e6cc...a1c968d. Read the comment docs.