-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Winforms Progressbar #2485
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It's currently failing CI because it's missing a changenote. It's also unclear if this will impact on tests - it feels like there should be an impact on tests.
FYI - you can ignore the test failures on Python 3.13 - there's been a regression in Freezegun that is incompatible with Python 3.13.0a6; the fix has been made upstream, but we're waiting on an updated release. However, the test failure on iOS does need to be resolved. You'll need to investigate why that test is failing and work around the issue, or find a way to make the test skip on iOS. |
A fix for the Python 3.13 issue can be found in #2498. |
Fixes #2430
PR Checklist: