Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Winforms Progressbar #2485

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SahilNagpure07
Copy link

Fixes #2430

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@proneon267
Copy link
Contributor

Just a heads up, #2430 is covered by #2484

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's currently failing CI because it's missing a changenote. It's also unclear if this will impact on tests - it feels like there should be an impact on tests.

@freakboy3742
Copy link
Member

freakboy3742 commented Apr 12, 2024

FYI - you can ignore the test failures on Python 3.13 - there's been a regression in Freezegun that is incompatible with Python 3.13.0a6; the fix has been made upstream, but we're waiting on an updated release.

However, the test failure on iOS does need to be resolved. You'll need to investigate why that test is failing and work around the issue, or find a way to make the test skip on iOS.

@freakboy3742
Copy link
Member

freakboy3742 commented Apr 12, 2024

A fix for the Python 3.13 issue can be found in #2498.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_background_supports_alpha should be added to WinForm ProgressBar
3 participants