Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Winforms Progressbar #2485

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fixes Winforms Progressbar #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
75ee2e3
fix-winforms-progressbar
SahilNagpure07 Apr 5, 2024
97aceb6
Merge branch 'beeware:main' into fix-2430
SahilNagpure07 Apr 6, 2024
1fce562
modified progressbar.py
SahilNagpure07 Apr 12, 2024
ad58048
added test
SahilNagpure07 Apr 12, 2024
b69d78c
added changenote
SahilNagpure07 Apr 12, 2024
36384d3
Merge branch 'fix-2430' of https://github.com/SahilNagpure07/toga int…
SahilNagpure07 Apr 12, 2024
d8a14b9
Merge branch 'beeware:main' into fix-2430
SahilNagpure07 Apr 12, 2024
565df63
Merge branch 'beeware:main' into fix-2430
SahilNagpure07 Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2485.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Exception raised by ProgressBar on Windows regarding transparent background has been resolved.
1 change: 1 addition & 0 deletions testbed/tests/widgets/test_progressbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import toga

from .properties import ( # noqa: F401
test_background_color_transparent,
test_enable_noop,
test_flex_horizontal_widget_size,
)
Expand Down
1 change: 1 addition & 0 deletions winforms/src/toga_winforms/widgets/progressbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

class ProgressBar(Widget):
TOGA_SCALE = 1000
_background_supports_alpha = False

def create(self):
self.native = WinForms.ProgressBar()
Expand Down
1 change: 1 addition & 0 deletions winforms/tests_backend/widgets/progressbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

class ProgressBarProbe(SimpleProbe):
native_class = System.Windows.Forms.ProgressBar
background_supports_alpha = False

@property
def is_determinate(self):
Expand Down
Loading