Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX snapML error #11
base: main
Are you sure you want to change the base?
FIX snapML error #11
Changes from 42 commits
7101b3d
07d07e4
a3890e4
ad52e93
c258167
da13bcd
443d5d2
f49311f
0b6d4f6
471ed52
22d92fb
da4dd69
30542b9
81060c4
47df2ae
82e70cf
e9544ce
0ea9a0f
8ef307d
aef59c6
c7f3842
606d470
97ef31c
85d5c12
c2ff09d
fa299bf
79b6758
75dc090
cb24345
b116218
7d57bff
0168495
f8535a7
5a56a2a
3f95a84
c241413
0f2e8a4
7b65b26
cb83036
a21301b
a8c4b7c
84ae029
9280d62
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test it, so I assume it worked on a machine you used @wassimmazouz ?
@tomMoral wdyt, is this overkill ? if the same resource is accessible online maybe we can just link to it in the snapml solver ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathurinm These were the minimal changes that helped pass the tests. However, I haven't tried this on any machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would just add a link to the tutorial in the
README
.