FIX snapML error #11
FIX snapML error #11
Conversation
|
@mathurinm original error solved. The remaining error in MacOS might be because |
|
The issue is that snapml released wheels built wtih numpy 1.*, that are not compatible with numpy 2. They do not release source (only wheels), so we cannot build the wheels ourselves. It's very constraining to pin versions exactly. Can you require "numpy<2" instead ? And add a comment above this line to explain why it's needed, so that it can be removed when adequate wheels are released (with a TODO) For libomp, go ahead ! |
.github/workflows/main.yml
Outdated
| @@ -16,7 +16,7 @@ on: | |||
|
|
|||
| jobs: | |||
| benchopt_dev: | |||
| uses: benchopt/template_benchmark/.github/workflows/test_benchmarks.yml@main | |||
| uses: wassimmazouz/template_benchmark/.github/workflows/test_benchmarks.yml@adding-libomp-install | |||
|
@mathurinm CI all 🟢. I've opened a PR on the template benchmark repository to incorporate these changes. |
| @@ -0,0 +1,58 @@ | |||
| ============================ | |||
There was a problem hiding this comment.
I can't test it, so I assume it worked on a machine you used @wassimmazouz ?
@tomMoral wdyt, is this overkill ? if the same resource is accessible online maybe we can just link to it in the snapml solver ?
There was a problem hiding this comment.
@mathurinm These were the minimal changes that helped pass the tests. However, I haven't tried this on any machine.
There was a problem hiding this comment.
Yes, I would just add a link to the tutorial in the README.
This PR aims to fix the incompatibility between current
snapmlandnumpyversions.