Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added STICK_COMMAND_EXECUTED beeper condition. #3568

Closed
wants to merge 1 commit into from
Closed

Added STICK_COMMAND_EXECUTED beeper condition. #3568

wants to merge 1 commit into from

Conversation

zvonler
Copy link

@zvonler zvonler commented Sep 6, 2023 •
edited by nerdCopter
Loading

First time contributor, these are changes to make available an optional beep when stick commands are executed. I did my best with the localization to mimic the grammar of the existing messages in the non-English locales.

BF changes to add feature: betaflight/betaflight#13069

@zvonler zvonler mentioned this pull request Sep 6, 2023
Closed
@blckmn
Copy link
Member

blckmn commented Sep 6, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@McGiverGim
Copy link
Member

You don't need to make the translations. They will be lost when we pull the translations files from Crowdin. Only English messages must be part of any PR.

@github-actions

This comment has been minimized.

Sign in to view
@zvonler
Copy link
Author

zvonler commented Sep 6, 2023

You don't need to make the translations. They will be lost when we pull the translations files from Crowdin. Only English messages must be part of any PR.

Ah, that makes sense. I'll take out the other languages.

@zvonler zvonler force-pushed the confirm_stick_commands branch from 9b964b4 to 1742e18 Compare September 6, 2023 13:28
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

McGiverGim
McGiverGim approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot this. It's ok!

@nerdCopter

This comment was marked as off-topic.

Sign in to view
@github-actions github-actions bot removed the Inactive label Oct 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@zvonler
Copy link
Author

zvonler commented Nov 9, 2023

Should still be viable.

@github-actions github-actions bot removed the Inactive label Nov 10, 2023
@haslinghuis
Copy link
Member

Closing as firmware PR got stalled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

Assignees

@zvonler zvonler

Labels
Needs coordination with firmware Pinned
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zvonler @blckmn @McGiverGim @nerdCopter @haslinghuis