Added optional beeps when stick commands are executed. #13069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
|
BF Configurator PR betaflight/betaflight-configurator#3568 |
|
AUTOMERGE: (FAIL)
|
|
Nice work. We will need some 'evidence' that it works - maybe make a small video? And perhaps some people to confirm it works for them. |
This comment was marked as outdated.
This comment was marked as outdated.
|
4.5 feature-freeze was Aug 7. Github indicates this is set for 4.6 unless core-dev's choose otherwise. |
nerdCopter
added
the
Pinned
haslinghuis
requested review from
a team,
ledvinap,
McGiverGim,
blckmn,
SteveCEvans,
KarateBrot and
nerdCopter
and removed request for
a team
blckmn
requested changes
Jun 28, 2024
| @@ -0,0 +1,329 @@ | |||
| /* | |||
| * This file is part of Cleanflight and Betaflight. | |||
There was a problem hiding this comment.
New licence file please see default licence in repo root.
There was a problem hiding this comment.
|
Closing as stalled / not implementing requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor, took a swing at what sounded like a simple and useful feature.
Fixes #12927
Also have the relevant configurator changes ready to go, wasn't sure if and how the two PRs need to be connected. I will open that one next and link to it in a comment.